Skip to content

docs(components): add accordion, breadcrumbs, media, and otp input to components page #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2025
Merged

docs(components): add accordion, breadcrumbs, media, and otp input to components page #4186

merged 5 commits into from
Jul 15, 2025

Conversation

joesphchang
Copy link
Contributor

@joesphchang joesphchang commented Jul 10, 2025 •
edited by brandyscarney
Loading

Resolves #3986

Changes I made

  • Utilized given screenshot to update components page.
  • Uploaded given photos into icons folder
  • Rearranged components page and wrote out description.
  • Ran npm run lint and npm run spellcheck with no errors.

@joesphchang joesphchang requested a review from a team as a code owner July 10, 2025 17:28
@joesphchang joesphchang requested a review from thetaPC July 10, 2025 17:28
@vercel Vercel
Copy link

vercel bot commented Jul 10, 2025

@joesphchang is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Jul 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 4:56pm

brandyscarney
brandyscarney approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice work! I have a few suggestions for the descriptions and noticed one incorrect link. I've shared it with our designer, so feel free to hold off on changes until I hear back, if that's easier. I'll let you know if they have any additional feedback. 🙂

@brandyscarney brandyscarney self-requested a review July 11, 2025 17:18
brandyscarney
brandyscarney requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are above I just accidentally submitted the review with the wrong selection. 🙂

@joesphchang
Copy link
Contributor Author

I'll make those changes tomorrow morning! I'm just catching up on all of the update!!

Thanks Brandy!

@brandyscarney
Copy link
Member

By the way I forgot to mention the designer didn't have any further feedback. 🙂

@joesphchang
Copy link
Contributor Author

I made those changes and hopefully It's looking great! I also fixed the weird code-blocks that were indented and now should all be consistent throughout.

Thank you again Brandy!

brandyscarney
brandyscarney approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work! 👏

@brandyscarney brandyscarney changed the title docs(component): added missing components docs(components): add accordion, breadcrumbs, media, and otp input to components page Jul 15, 2025
@brandyscarney brandyscarney merged commit 6f5a148 into ionic-team:main Jul 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC Awaiting requested review from thetaPC thetaPC is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

content: accordion missing on the component page
2 participants
@joesphchang @brandyscarney